fix(writer): fix commit URL for Gitlab repos (#40)

lob · Mar 28, 2018 · 656a2bc · 656a2bc
1 parent 797909e
commit 656a2bc
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/lib/writer.js b/lib/writer.js
@@ -33,6 +33,10 @@ exports.getCommitUrl = function (baseUrl, commitHash) {
     urlCommitName = 'commits';
   }
 
+  if (baseUrl.indexOf('gitlab') !== -1 && baseUrl.slice(-4) === '.git') {
+    baseUrl = baseUrl.slice(0, -4);
+  }
+
   return baseUrl + '/' + urlCommitName + '/' + commitHash;
 };
 

diff --git a/test/writer.test.js b/test/writer.test.js
@@ -26,6 +26,15 @@ describe('writer', function () {
       Expect(linkUrl).to.equal(url + '/commit/' + commitHash);
     });
 
+    it('makes a valid URL for a Gitlab repository', function () {
+      var url = 'https://gitlab.com/lob/generate-changelog.git';
+      var expectedUrl = 'https://gitlab.com/lob/generate-changelog';
+      var commitHash = '1234567890';
+
+      var linkUrl = Writer.getCommitUrl(url, commitHash);
+      Expect(linkUrl).to.equal(expectedUrl + '/commit/' + commitHash);
+    });
+
   });
 
   describe('markdown', function () {