Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emr serverless python dependencies #250

Merged
merged 8 commits into from
Jul 18, 2024

Conversation

cloutierMat
Copy link
Contributor

Motivation

Adding a sample for aws emr serverless. This will showcase a workaround to allow using a custom python environment with localstack

@cloutierMat cloutierMat requested a review from HarshCasper July 12, 2024 23:56
@cloutierMat cloutierMat self-assigned this Jul 12, 2024
@cloutierMat cloutierMat marked this pull request as draft July 12, 2024 23:59
@cloutierMat
Copy link
Contributor Author

@HarshCasper I haven't added the test for it, as it would be a bigdata test requiring big install... not sure we want to add that here.
Also there is still a pr needing to be merge before this can work. Just created it to be ready! ;)

@cloutierMat cloutierMat marked this pull request as ready for review July 17, 2024 01:06
@cloutierMat
Copy link
Contributor Author

I noticed there were other big data sample with test, so I added the tests 😉

Copy link
Member

@HarshCasper HarshCasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It needs some cosmetic changes which can be done latter 👍

@cloutierMat cloutierMat merged commit ec34fa0 into master Jul 18, 2024
1 check passed
@cloutierMat cloutierMat deleted the emr_serverless_python_dependencies branch July 18, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants