Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from nose test to pytest #4193

Merged
merged 2 commits into from
Jun 27, 2021
Merged

Migrate from nose test to pytest #4193

merged 2 commits into from
Jun 27, 2021

Conversation

thrau
Copy link
Member

@thrau thrau commented Jun 23, 2021 •
edited
Loading

This PR builds on #4008 and adds a more elaborate starting procedure that we also use in https://github.com/localstack/localstack-terraform-test (i added documentation).

other changes:

  • some deprecation warnings in tests
  • added a check in the TestTerraform integration test that will skip the test if the terraform command fails
  • add pytest plugin that can re-run failed integration tests

@thrau thrau marked this pull request as ready for review June 23, 2021 21:44
@thrau thrau requested a review from whummer June 23, 2021 21:44
@thrau thrau force-pushed the migrate-pytest branch 2 times, most recently from 5795eee to fcdbdb2 Compare June 25, 2021 15:22
@thrau thrau marked this pull request as draft June 25, 2021 15:25
@thrau thrau force-pushed the migrate-pytest branch 2 times, most recently from b7487f3 to 70b94a1 Compare June 26, 2021 16:41
@thrau thrau marked this pull request as ready for review June 27, 2021 08:52
@thrau
Copy link
Member Author

thrau commented Jun 27, 2021 •
edited
Loading

build times look good! tests pass! 🤯

looks like we can get this over the line @whummer :-)

i will solve the issue with coverage in a separate PR that i will update once pytest is active #4206

@whummer
Copy link
Member

whummer commented Jun 27, 2021

Awesome PR - great to see we can get this one over the line. 🎉 Thanks @thrau 👍 , and kudos to @tirkarthi for the initial version of this change!! 🚀

@whummer whummer merged commit 5332790 into master Jun 27, 2021
@whummer whummer deleted the migrate-pytest branch June 27, 2021 10:24
@whummer
Copy link
Member

whummer commented Jun 27, 2021

Merged - @tirkarthi we've made sure that your original authorship is retained in the commit history.. Thanks!

@tirkarthi
Copy link
Contributor

Thanks @whummer and @thrau

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whummer whummer whummer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thrau @whummer @tirkarthi