Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpRangeReader swallows 404s #2791

Closed
metasim opened this issue Aug 22, 2018 · 0 comments · Fixed by #3073
Closed

HttpRangeReader swallows 404s #2791

metasim opened this issue Aug 22, 2018 · 0 comments · Fixed by #3073
Assignees
@CloudNiner
Labels
good first issue

Comments

@metasim
Copy link
Member

metasim commented Aug 22, 2018

If you attempt to do a range read on something doesn't exist, you get an IllegalArgumentException instead of a 404:

geotrellis/spark/src/main/scala/geotrellis/spark/io/http/util/HttpRangeReader.scala

Line 56 in 835200c

require(headers.header("Accept-Ranges") == Some("bytes"),

CloudNiner added a commit to CloudNiner/geotrellis that referenced this issue Sep 16, 2019
@CloudNiner
Fix locationtech#2791: HttpRangeReader swallows 404s
2276225 
HttpRangeReader now throws with an
HttpStatusException if the server responds
with any 4xx or 5xx status code.
@CloudNiner CloudNiner mentioned this issue Sep 16, 2019
Merged
4 tasks
echeipesh added a commit that referenced this issue Sep 16, 2019
@echeipesh
Merge pull request #3073 from CloudNiner/feature/awf/http-range-swall…
ec65295 
…ows-404#2791

Fix #2791: HttpRangeReader swallows 404s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CloudNiner CloudNiner

Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #2791: HttpRangeReader swallows 404s CloudNiner/geotrellis
2 participants
@metasim @CloudNiner