-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example: VoxelKey #1639
Example: VoxelKey #1639
Conversation
- An English explanation of `VoxelKey.scala`
|
||
And with a `KeyIndex` written, it will of course need its own `JsonFormat`, | ||
which demands some additional glue to make fully functional. For more | ||
details, see `ShardingKeyIndex.scala`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think it is important to add a reference or explanations of how to use custom registrator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's included in custom-keyindex.md
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, sorry; thx for pointing that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mb all refereneces to make links? ShardingKeyIndex.scala
can be a link as well.
|
||
*Want to jump straight to a code example? See:* | ||
``` | ||
doc-examples/src/main/scala/geotrellis/doc/examples/spark/VoxelKey.scala |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make it a link?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
``` | ||
|
||
Where the pattern `[A: Trait1: Trait2: ...]` means that for whichever `A` | ||
you end up using, it must have an implicit instance of `Trait1` and `Trait2` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trait1[K]
and Trait2[K]
as [A: Trait1: Trait2: ...]
expands to [A](ev0: Trait1[A], ev1: Trait2[A])
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, it's just syntactic sugar.
|
||
And with a `KeyIndex` written, it will of course need its own `JsonFormat`, | ||
which demands some additional glue to make fully functional. For more | ||
details, see `ShardingKeyIndex.scala`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mb all refereneces to make links? ShardingKeyIndex.scala
can be a link as well.
I might be forgetting to implement a |
|
||
*Want to jump straight to a code example? See:* | ||
``` | ||
doc-examples/src/main/scala/geotrellis/doc/examples/spark/VoxelKey.scala |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
} | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are missing SpatialComponent
Example documentation on how to implement a new key type, used in
KeyIndex
es and many GeoTrellis operations.