-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize ColorMap #1648
Merged
lossyrob
merged 10 commits into
locationtech:master
from
fosskers:fix/cgw/optimize-colormap
Oct 5, 2016
Merged
Optimize ColorMap #1648
lossyrob
merged 10 commits into
locationtech:master
from
fosskers:fix/cgw/optimize-colormap
Oct 5, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Memoize the results of `map` in a `TrieMap` for faster subsequent lookups. A more involved custom binary search could be employed for faster lookups in `DoubleColorMap`, as it can't take advantage of `TrieMap` in the same way.
- A generalized binary search with a custom "target test" predicate.
- Also, `BTree` can print itself now. Should convert to returning a `String` instead.
Bonus, └── 4
├── 6
│ ├── 7
│ │ ├── ∅
│ │ └── ∅
│ └── 5
│ ├── ∅
│ └── ∅
└── 2
├── 3
│ ├── ∅
│ └── ∅
└── 1
├── ∅
└── ∅ |
Don't merge yet: I still need to run benchmarks. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Let:
k
be the number of pixels to colour, andn
the number of colour breaks, where usuallyk > n
by several orders of magnitudeTrieMap
to memoizeIntColorMap.map
resultsO(kn)
O(k + n)
BTree[T]
BTree
forDoubleColorMap
O(nlogn + klogn) == O((n + k)logn) ~= O(klogn)
BTree.pretty
should returnString
BTree
forIntColorMap
Motivation
This addresses #1489 . Currently every call to
IntColorMap.map
orDoubleColorMap.map
performs aO(n)
search for the correct colour ramp value, given some raster's pixel value. The total cost to colour a raster is thenO(kn)
.Next Steps
Use Spire to generalize over
Int
andDouble
?