Add SparkSession into TestEnvironment #2808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pomadchin |
|
@metasim nothing had changed ._. all old function calls are the same. |
Signed-off-by: Grigory Pomadchin <[email protected]>
Signed-off-by: Grigory Pomadchin <[email protected]>
pomadchin
force-pushed
the
feature/improved-testenv
branch
from
5171c6c to
2fb799f
Compare
pomadchin
commented
Sep 27, 2018
| @@ -3,7 +3,8 @@ import Dependencies._ | |||
| name := "geotrellis-spark-testkit" | |||
|
|
|||
| libraryDependencies ++= Seq( | |||
| sparkCore % Provided , | |||
| sparkCore % Provided, | |||
| sparkSQL % Provided, | |||
There was a problem hiding this comment.
@metasim mb it makes sense to remove this Provided flag?
echeipesh
approved these changes
Oct 2, 2018
|
Backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds spark-sql dependency into
spark-testkitproject and modifiesTestEnvironmenttrait to containSparkSessionA new dependency doesn't really hurt as, as it is a dependency into a test sub project.
Closes #2498