Fix Tiled TIFF BitCellType Segments conversion #3102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomadchin
commented
Oct 1, 2019
| assertEqual(tiffTile.toArrayTile(), tile.toArrayTile) | ||
|
|
||
| // check that it is possible to convert int cellType to bit cellType | ||
| // and that bitCellType conversion is idempotent |
There was a problem hiding this comment.
This requires idempotence check, since it is the best way to prove that we're setting / unsetting and inverting bits correct to check that even / odd number of conversions would not affect the final result.
pomadchin
force-pushed
the
feature/tiled-bit-tiff-fix
branch
3 times, most recently
from
f30b97c to
048174c
Compare
pomadchin
changed the title
Signed-off-by: Grigory Pomadchin <[email protected]>
Signed-off-by: Grigory Pomadchin <[email protected]>
pomadchin
force-pushed
the
feature/tiled-bit-tiff-fix
branch
from
c953e82 to
a932efc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes
GeoTIffTileCellTypeconversion, in particularGeoTiffSegmentCellTypeconversions. During the work on this fix, it became obvious that our TIFF API doesn't support a proper work withstripedBitTiffs(this fact made this issue debugging a bit more tricky), that is why this PR at least coversTiledtiffs support.Checklist
docs/CHANGELOG.rstupdated, if necessaryFixes #3055
Note
This issue indeed closes #3055 in any case, since COGs are Tiled TIFFs. If this PR won't cover
StripedTIFFs support, I will create a separate issue to address it. This PR blocks a 3.0 release, a complete striped bit TIFFs support does not.