Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix StreamingByteReader over-allocation past EOF #3138

Merged
merged 3 commits into from
Oct 23, 2019
Merged

Fix StreamingByteReader over-allocation past EOF #3138

merged 3 commits into from
Oct 23, 2019

Conversation

echeipesh
Copy link
Contributor

@echeipesh echeipesh commented Oct 23, 2019 •
edited by pomadchin
Loading

Overview

Extracts bug fix from #3135

When reading past end of file StreamingRangeReader would allocate array for the site it was intending to read, rather than actual size that was read when requested read range is past EOF.

Checklist

@echeipesh echeipesh added the bug label Oct 23, 2019
pomadchin
pomadchin approved these changes Oct 23, 2019
View reviewed changes
Copy link
Member

@pomadchin pomadchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@echeipesh echeipesh mentioned this pull request Oct 23, 2019
Closed
3 tasks
@echeipesh echeipesh merged commit 49bb7e2 into locationtech:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pomadchin pomadchin pomadchin approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@echeipesh @pomadchin