Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate circe json codec #3181

Conversation

notthatbreezy
Copy link

@notthatbreezy notthatbreezy commented Feb 6, 2020

Overview

This removes a duplicate codec for TileLayout - there is already one here and it is really easy to get in a situation where both are available and hit an ambiguous implicit error.

Checklist

@pomadchin
Copy link
Member

pomadchin commented Feb 6, 2020

Ah, it looks like you also need to sign ECA, could you do it if it is not hard for you?

If you have / once you'll have a signed ECA you can sign your commit via
git commit --amend -s && git push origin -f feature/cmb/remove-duplicate-json-codec

Christopher Brown added 2 commits February 6, 2020 22:11
Signed-off-by: Christopher Brown <[email protected]>
@notthatbreezy notthatbreezy force-pushed the feature/cmb/remove-duplicate-json-codec branch from c1d17fb to da5ebc4 Compare February 7, 2020 03:12
@notthatbreezy
Copy link
Author

@pomadchin Updated PR and signed ECA

I also added a commit that removed the private restriction on an overload for reading tiff tags -- this wasn't in previous versions of GT and RF uses this method and another project now.

Copy link
Member

@pomadchin pomadchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank Chris! Looks good to me, merging once Travis is happy; and after updating the changelog :d

Signed-off-by: Christopher Brown <[email protected]>
@notthatbreezy
Copy link
Author

Changelog updated!

@pomadchin
Copy link
Member

@notthatbreezy perfect, thanks!

@pomadchin pomadchin merged commit 92b4da1 into locationtech:master Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants