-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate circe json codec #3181
Remove duplicate circe json codec #3181
Conversation
Ah, it looks like you also need to sign ECA, could you do it if it is not hard for you? If you have / once you'll have a signed ECA you can sign your commit via |
Signed-off-by: Christopher Brown <[email protected]>
Signed-off-by: Christopher Brown <[email protected]>
c1d17fb
to
da5ebc4
Compare
@pomadchin Updated PR and signed ECA I also added a commit that removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank Chris! Looks good to me, merging once Travis is happy; and after updating the changelog :d
Signed-off-by: Christopher Brown <[email protected]>
Changelog updated! |
@notthatbreezy perfect, thanks! |
Overview
This removes a duplicate codec for
TileLayout
- there is already one here and it is really easy to get in a situation where both are available and hit an ambiguous implicit error.Checklist