Fix GeoTrellisRasterSources to properly pass time though all the internal functions #3226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomadchin
force-pushed
the
fix/geotrellis-rs
branch
from
737a1aa to
bd08811
Compare
pomadchin
force-pushed
the
fix/geotrellis-rs
branch
from
bd08811 to
92956d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We had a broken GeoTrellisRasterSources temporal support that was revelaed in terms of geotrellis/geotrellis-server#248
This PR fixes the bad GeoTrellisRasterSoruces behavior.
Brief description of what this PR does, and why it is needed. The issue #3225 is still valid.
However, because GeoTrellisRasterSources work only with a single temporal slice. index overflows during the query ranges generation should never happen.
Checklist
Addresses geotrellis/geotrellis-server#248