Fix MosaicRasterSource, GDALRasterSource and GeoTiffResampleRasterSource behavior #3252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomadchin
changed the title
pomadchin
changed the title
pomadchin
changed the title
pomadchin
force-pushed
the
fix/mosaic-rs
branch
2 times, most recently
from
3855874 to
60b9945
Compare
pomadchin
commented
Jun 9, 2020
| MosaicRasterSource( | ||
| sources map { _.reproject(targetCRS, resampleTarget, method, strategy) }, | ||
| crs, | ||
| gridExtent.reproject(this.crs, targetCRS, Reproject.Options.DEFAULT.copy(method = method)), |
There was a problem hiding this comment.
This gives an incorrect CellSize
CloudNiner
reviewed
Jun 9, 2020
raster/src/main/scala/geotrellis/raster/MosaicRasterSource.scala
Outdated
Show resolved
Hide resolved
pomadchin
changed the title
pomadchin
force-pushed
the
fix/mosaic-rs
branch
2 times, most recently
from
89daec1 to
d841cb5
Compare
pomadchin
changed the title
CloudNiner
reviewed
Jun 10, 2020
CloudNiner
approved these changes
Jun 10, 2020
There was a problem hiding this comment.
Looks good overall, although it appears there's a failing GDAL test on Scala 2.11 in CI that I couldn't reproduce locally.
Also good to add some docs before merging to MosaicRasterSource instance and apply methods that describe how and why you'd want to use each, e.g. needing to conform all rasters to a target grid extent.
pomadchin
force-pushed
the
fix/mosaic-rs
branch
2 times, most recently
from
7fe3249 to
cc1d1f4
Compare
pomadchin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes:
Checklist