Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rasters S3 write methods #3333

Merged
merged 2 commits into from
Jan 22, 2021
Merged

Add rasters S3 write methods #3333

merged 2 commits into from
Jan 22, 2021

Conversation

pomadchin
Copy link
Member

@pomadchin pomadchin commented Jan 12, 2021 •
edited
Loading

Overview

This PR adds a specific to s3 overload that doesn't require having a hadoop dependency in the classpath.

Checklist

  • ./CHANGELOG.md updated, if necessary. Link to the issue if closed, otherwise the PR.

Demo

val tiff: MultibandGeoTiff = ???
tiff.write(new AmazonS3URI("s3://test/destination.tiff"))

pomadchin
pomadchin commented Jan 12, 2021
View reviewed changes
scalastyle-config.xml Outdated Show resolved Hide resolved
@pomadchin pomadchin force-pushed the feature/s3-tiff-write branch 3 times, most recently from bb487e4 to e7fd41a Compare January 12, 2021 00:20
@pomadchin pomadchin force-pushed the feature/s3-tiff-write branch from e7fd41a to ca0f75e Compare January 12, 2021 00:42
echeipesh
echeipesh approved these changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@echeipesh echeipesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quality of live PR is quality 👍

@pomadchin pomadchin merged commit 2f8348a into locationtech:master Jan 22, 2021
@pomadchin pomadchin deleted the feature/s3-tiff-write branch January 22, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echeipesh echeipesh echeipesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pomadchin @echeipesh