Fix AWS S3LayerDeleter #3378
Merged
Fix AWS S3LayerDeleter #3378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 6, 2021 16:24
…e iteration of objects to delete
…s for a given zoom level
|
@zacharyDez don’t worry, I think the change good as it is, thanks for catching the small bug 👍 Hmm, could you rebase on top of master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Relates to previously closed #3371.
An error is thrown due to trying to delete the attribute information of a layerId previously deleted. The fix was simply to remove the call to the attribute store outside of the foreach loop.
Checklist
docsguides update, if necessaryNotes
Probably should consider implementing an integration/unit test
Closes #3371