Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WKTReader: parsing error not propagated #785

Closed
alexismanin opened this issue Oct 19, 2021 · 2 comments
Closed

WKTReader: parsing error not propagated #785

alexismanin opened this issue Oct 19, 2021 · 2 comments
Assignees
Labels

Comments

@alexismanin
Copy link

Hello,

For some cases, a null value is returned from the WKTReader instead of propagating a ParseException.
I do not see any linked documentation, so I think it is a mistake.

The related code is:

If you confirm it is a bug, I'll try to submit a minimal PR in a near future.

Regards,

@dr-jts
Copy link
Contributor

dr-jts commented Oct 19, 2021

Yes, that's definitely a bug. The try-catch should simply be removed, so the exceptions can propagate upwards.

It also looks like the parsing of the geometry type keywords is flawed - it allows spurious characters between the type and the dimension modifiers (e.g. POINTABCZ (0 0)).

I'll fix both of these in a single PR shortly.

@dr-jts dr-jts self-assigned this Oct 19, 2021
@dr-jts dr-jts changed the title WKT reader: parsing error not propagated WKTReader: parsing error not propagated Oct 19, 2021
@dr-jts
Copy link
Contributor

dr-jts commented Oct 19, 2021

Fixed by #786.

@dr-jts dr-jts closed this as completed Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants