Fix WKTReader typename parsing #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Davis <[email protected]>
teleivo
added a commit
to dhis2/dhis2-core
that referenced
this pull request
Jul 29, 2022
as locationtech/jts parser has either gotten stricter or not reported such parser errors before locationtech/jts#786
teleivo
added a commit
to dhis2/dhis2-core
that referenced
this pull request
Jul 29, 2022
as locationtech/jts parser has either gotten stricter or not reported such parser errors before locationtech/jts#786
teleivo
added a commit
to dhis2/dhis2-core
that referenced
this pull request
Jul 29, 2022
as locationtech/jts parser has either gotten stricter or not reported such parser errors before locationtech/jts#786
teleivo
added a commit
to dhis2/dhis2-core
that referenced
this pull request
Jul 30, 2022
* chore(deps): bump jts.version from 1.18.2 to 1.19.0 in /dhis-2 Bumps `jts.version` from 1.18.2 to 1.19.0. Updates `jts-core` from 1.18.2 to 1.19.0 Updates `jts-io-common` from 1.18.2 to 1.19.0 --- updated-dependencies: - dependency-name: org.locationtech.jts:jts-core dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.locationtech.jts.io:jts-io-common dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * fix: error parsing event geometry during CSV import * fix: parsing geometry with leading single quotes as locationtech/jts parser has either gotten stricter or not reported such parser errors before locationtech/jts#786 * fix: sonarqube suggestion Alternatives in regular expressions should be grouped when used with anchors * Revert "fix: sonarqube suggestion" This reverts commit 6f3c72c. as Sonarqube is now saying that I should remove these unecessary groups Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: teleivo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
WKTReadergeometry typename parsing to detect and error on extraneous characters between the typename and dimension modifiers suffix.Fixes a bug in
WKBReaderTestwhich was hidden by the lax parsing.Also fixes the unnecessary try-catch reported in #785.
Signed-off-by: Martin Davis [email protected]