Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit example of snapshot use, mentioning build server. #488

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

jodygarnett
Copy link
Contributor

No description provided.

@jodygarnett jodygarnett requested a review from dr-jts October 15, 2019 22:52

### Using JTS Snapshots

Our [build server](https://ci.eclipse.org/jts/) publishes to the LocationTech Maven repository. To include JTS in a project, add the following repositories to the pom:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change link to JTS artifacts: https://ci.eclipse.org/jts/job/JTS_deploy_snapshots/

JTS snapshot artifacts are published to the LocationTech Maven repository. To include JTS in a project, add the following repositories to the pom.
JTS artifacts are available on maven central.

### Using JTS Snapshots
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be good to refer to this link somewhere, since it's where the snapshots are found?

https://repo.locationtech.org/content/repositories/jts-snapshots/org/locationtech/jts/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specifying repo.locationtech.org should be enough. I think the LT repo unifies all the various sub-repos into a consistent view, etc.

@@ -73,7 +93,8 @@ Older versions of JTS are available on Maven Central.
<version>1.14.0</version>
</dependency>
```
### 1.13

JTS 1.13:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want this to be bold? If so, we should keep the hashes, no? (I don't do much with MD, but I think that's right.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashes are for headings, (bold / strong / emphasis uses double asterix), semantically you probably need 4-hashes #### to denote sub-heading (definition-lists are a total pain in GH-markdown)

@dr-jts dr-jts merged commit 6621f77 into master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants