Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix STRtree queries on empty trees #886

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

dr-jts
Copy link
Contributor

@dr-jts dr-jts commented Jun 3, 2022

Fixes the following STRtree queries on empty trees:

  • Object nearestNeighbour(Envelope env, Object item, ItemDistance itemDist) - returns null for empty tree
  • Object[] nearestNeighbour(Envelope env, Object item, ItemDistance itemDist,int k) - returns Object[0] for empty tree

Fixes #881.
Fixes #884.

Signed-off-by: Martin Davis [email protected]

@ashr123
Copy link

ashr123 commented Jun 3, 2022

@dr-jts can you merge my PRs to your branch and just add the unit test and merge it all together to locationtech:master?

@dr-jts
Copy link
Contributor Author

dr-jts commented Jun 3, 2022

dr-jts can you merge my PR to your branch?

No need to, everything is in this PR.

@dr-jts dr-jts merged commit e61027a into locationtech:master Jun 3, 2022
@dr-jts dr-jts deleted the fix-strtree-query-empty branch June 3, 2022 18:32
@ashr123
Copy link

ashr123 commented Jun 3, 2022

dr-jts can you merge my PR to your branch?

No need to, everything is in this PR.

In this way my contribution could have been noticed

@jodygarnett jodygarnett added this to the 1.19.0 milestone Jun 21, 2022
@jodygarnett jodygarnett modified the milestones: 1.19.0, 1.20.0 Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants