refactor: Drop legacy constants module imports and methods (#342)

* refactor: Drop imports from redundant constants module

* refactor: Cease using legacy numeric constants

lib/src/core/handle.rs

@@ -2,10 +2,7 @@
 // SPDX-License-Identifier: MPL-2.0
 // Copyright (C) 2017-2024 Adam Lock
 
-use std::{
-    sync::atomic::{AtomicU32, Ordering},
-    u32,
-};
+use std::sync::atomic::{AtomicU32, Ordering};
 
 /// A simple handle factory for incrementing sequences of numbers.
 #[derive(Debug, Clone, Serialize)]

lib/src/server/address_space/address_space.rs

@@ -216,7 +216,6 @@ impl AddressSpace {
     /// The last registered namespace becomes the default namespace unless you explcitly call
     /// `set_default_namespace()` after this.
     pub fn register_namespace(&mut self, namespace: &str) -> Result<u16, ()> {
-        use std::u16;
         let now = DateTime::now();
         if namespace.is_empty() || self.namespaces.len() == u16::MAX as usize {
             Err(())

lib/src/server/address_space/variable.rs

@@ -455,8 +455,6 @@ impl Variable {
         data_encoding: &QualifiedName,
         max_age: f64,
     ) -> DataValue {
-        use std::i32;
-
         if let Some(ref value_getter) = self.value_getter {
             let mut value_getter = value_getter.lock();
             value_getter

lib/src/server/config.rs

@@ -19,8 +19,8 @@ use super::constants;
 
 pub const ANONYMOUS_USER_TOKEN_ID: &str = "ANONYMOUS";
 
-const RECEIVE_BUFFER_SIZE: usize = std::u16::MAX as usize;
-const SEND_BUFFER_SIZE: usize = std::u16::MAX as usize;
+const RECEIVE_BUFFER_SIZE: usize = u16::MAX as usize;
+const SEND_BUFFER_SIZE: usize = u16::MAX as usize;
 
 #[derive(Debug, PartialEq, Serialize, Deserialize, Clone)]
 pub struct TcpConfig {

lib/src/server/services/view.rs

@@ -182,7 +182,6 @@ impl ViewService {
                                 }
                                 Ok(result) => {
                                     let targets = if !result.is_empty() {
-                                        use std::u32;
                                         let targets = result
                                             .iter()
                                             .map(|node_id| BrowsePathTarget {

lib/src/server/subscriptions/subscription.rs

@@ -485,7 +485,6 @@ impl Subscription {
     }
 
     fn enqueue_notification(&mut self, notification: NotificationMessage) {
-        use std::u32;
         // For sanity, check the sequence number is the expected sequence number.
         let expected_sequence_number = if self.last_sequence_number == u32::MAX {
             1

lib/src/types/date_time.rs

@@ -161,7 +161,7 @@ impl From<DateTimeUtc> for DateTime {
 
 impl From<i64> for DateTime {
     fn from(value: i64) -> Self {
-        if value == i64::max_value() {
+        if value == i64::MAX {
             // Max signifies end times
             Self::endtimes()
         } else {
@@ -315,7 +315,7 @@ impl DateTime {
             return 0;
         }
         if nanos > Self::endtimes_ticks() {
-            return i64::max_value();
+            return i64::MAX;
         }
         nanos
     }

lib/src/types/expanded_node_id.rs

@@ -8,7 +8,6 @@ use std::{
     self, fmt,
     io::{Read, Write},
     str::FromStr,
-    u16, u32,
 };
 
 use serde::{de, Deserialize, Deserializer, Serialize, Serializer};

lib/src/types/node_id.rs

@@ -11,7 +11,6 @@ use std::{
     io::{Read, Write},
     str::FromStr,
     sync::atomic::{AtomicUsize, Ordering},
-    u16, u32,
 };
 
 use serde::{de, Deserialize, Deserializer, Serialize, Serializer};

lib/src/types/variant.rs

@@ -10,7 +10,6 @@ use std::{
     fmt,
     io::{Read, Write},
     str::FromStr,
-    {i16, i32, i64, i8, u16, u32, u64, u8},
 };
 
 use crate::types::{

lib/src/types/variant_json.rs

@@ -15,7 +15,7 @@
 //! To distinguish between binary and JSON, the built-in types implement Serde's `Serialize`/`Deserialize`
 //! traits for JSON serialization.
 
-use std::{fmt, i32};
+use std::fmt;
 
 use serde::{
     de, de::DeserializeOwned, de::Error, Deserialize, Deserializer, Serialize, Serializer,