Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code restructuring. #691

Closed
proyan opened this issue Feb 17, 2020 · 2 comments
Closed

Code restructuring. #691

proyan opened this issue Feb 17, 2020 · 2 comments

Comments

@proyan
Copy link
Member

proyan commented Feb 17, 2020

@wxmerkt @PepMS @VladimirIvan @nim65s @cmastalli @MaximilienNaveau

In order to use CodeGen on crocoddyl ActionModels, I'm restructuring the code on the Scalar template. This PR would be available in this week.
There would be no change in API, and it wouldn't affect your dependent code.
Nevertheless, I opened this issue so you could let me know if you see any way this might affect your ongoing work, and if so, how we could plan the merge schedule.
@cmastalli
Copy link
Member

Please do not modify anything that is not in the scope of this task.
I am trying to prevent much bigger PRs.

Consider that there is 20% of the code that it is not currently tested in our CI.

@proyan proyan mentioned this issue Feb 20, 2020
Merged
@proyan
Copy link
Member Author

proyan commented Mar 2, 2020

Fixed with #695

@proyan proyan closed this as completed Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cmastalli @proyan