-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Refactoring on Template Scalar #695
Conversation
[action-base] calcdiff with recalc argument [unicycle] unneeded include in hxx file
Thanks for finding those! I haven't looked at the implementation in this PR, this is only the refactoring. The code is exactly the same as before. |
CI fails with |
No, it is because the Python bindings of Crocoddyl are not well done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main important changes are:
- Do not implement methods in hpp file, move them to hxx (activation classes, actuation-full)
- Instantiate the multibody classes in crocoddyl/fwd.hpp (if this is not done, I am not sure :))
There are other minor changes to do:
- Add vertical skip
- Rename typedef to follow standard and avoid general names
- Rename
MathBaseTpl
toEigenS
- Add typedef for pinocchio stuffs
@proyan despite that the PR was terrible long, I am happy that you made it the easiest possible.
Thank you so much for this awesome contribution!!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main important changes are:
- Do not implement methods in hpp file, move them to hxx (activation classes, actuation-full)
- Instantiate the multibody classes in crocoddyl/fwd.hpp (if this is not done, I am not sure :))
There are other minor changes to do:
- Add vertical skip
- Rename typedef to follow standard and avoid general names
- Rename
MathBaseTpl
toEigenS
- Add typedef for pinocchio stuffs
@proyan despite that the PR was terrible long, I am happy that you made it the easiest possible.
Thank you so much for this awesome contribution!!!!
Thanks for the review Carlos. Unfortunately, I don't agree with many parts of your review.
These are often one line implementations, and it is not really different to have them in hxx files.
The classes are instantiated.
There is no standard or general naming that is followed. I'm sorry but I don't agree with your suggestions.
Again, I'm sorry but I don't agree.
Again, I'm sorry but I don't agree, see the comments in review. |
The reason of splitting into two files is to boost compilation. MathBase is very general, that namespace could exist in any package. Some typedef naming are not following any stile. Having Base is too general and hard to read. Typedef for pinocchio stuff are not fundamental but they help to read the code. We could skip them for now. |
d6fc5a4
to
864a507
Compare
864a507
to
79a887c
Compare
9ef5235
to
4d37976
Compare
@proyan the code is nice, thanks! |
This PR refactors the code based on the Scalar template.
This PR follows the issue in #691. This is a big change in the current code structure, and thus I want to make sure that all our partners are well aware of this.
There is no new feature being added in this PR, and this PR only focuses on the code refactoring.