Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ruff mypy #2978

Merged
merged 2 commits into from
Nov 9, 2024
Merged

Update ruff mypy #2978

merged 2 commits into from
Nov 9, 2024

Conversation

tdadela
Copy link
Contributor

@tdadela tdadela commented Nov 9, 2024

Unpin poetry: ruff is pinned to one particular version to keep the same version as in .pre-commit-config.yaml. I don't see reasons for poetry to be pinned. (Especially since adding poetry.lock file to the repo).
Bump ruff: there were a lot of improvements over the last half year (including better detection of old style string interpolation #2974).

@cyberw
Copy link
Collaborator

cyberw commented Nov 9, 2024

Pinning ruff/mypy was because new versions of those can cause a new build to fail with no source change. But its probably a smaller issue than accidentally having really old versions..

@cyberw cyberw merged commit 6b40e26 into locustio:master Nov 9, 2024
17 checks passed
@tdadela tdadela deleted the update-ruff-mypy branch November 9, 2024 21:23
@tdadela
Copy link
Contributor Author

tdadela commented Nov 9, 2024

Makes sense.
Just to clarify and be sure that we are on the same:
poetry install uses the exact versions from poetry.lock.
So someone will install newer version of mypy only if that person intentionally execute poetry update (or add new dependency or execute other similar command).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants