-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement composer #1315
base: master
Are you sure you want to change the base?
Implement composer #1315
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job 🔥 Congrats! 🎉
Some quick observations:
-
The full path, details and the buttons in this top section look pretty big overall, might be better to make them smaller?
-
After clicking "Apply", there's a noticeable lag before the diff view is opened. It's fine to have a lag but it would be a nice UX improvement to add a spinner on the Apply button so that it doesn't look like nothing is happening for a second after clicking it.
-
When there's nothing accepted, I click "Apply Accepted Changes" it just closes the diff view without anything changed. This is reasonable function-wise but a bit awkward on the UX side - user might think it's "Apply All" or they didn't realize they didn't accept anything. Is it better to have an "Apply all / or accepted changes", if nothing is accepted explicitly, it just acts like "Apply all"; if anything accepted, it applies those. Open to other ideas.
-
When there's only one diff block with Accept / Reject, is it better to make the block-level Accept / Reject act like the global ones and close the diff view? It seems unnecessary to click the top ones again for a single block.
WDYT? @wenzhengjiang
I was thinking the exact same thing when I first saw the demo. The UX of accepting diff has been pretty standardized. The same pattern has been used not only for the latest AI editing, but also has been like that since the git diff experience. I would highly recommend us to mimic a similar experience. |
Thanks for the good UX feedbacks!
Or they could just click the top ones since there is only one block? Not sure we want to change the behavior of the buttons for this specific case. |
@logancyang @zeroliu I think I have addressed all your concerns. I'm pretty new to web frontend, so I could be still missing something... Currently I'm using the default variant for accept/apply buttons and secondary variant for reject buttons. They look like below: ![]() Open to making the green and red changes if you think they’re worth it. |
This is quite large PR containing below major changes: