Avoid assumed-rank arrays in MPI_Utilities #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andres-MG
force-pushed
the
fix/MPIutils
branch
from
9da794a to
62d4137
Compare
|
@Andres-MG, once the conflicts are resolved, let me know so I can force the merge. Thanks |
|
All seems to be good now. I guess the errors are related to the gfortran+MKL issues we've seen before... How much should we increase the tolerance of those tests to get an OK? |
|
For now, I am skipping those test cases with gfortran. I think we need to further investigate the issue before increasing the tolerance |
|
@Andres-MG, the merge is finished. Delete the branch if you don't need it anymore. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assumed-rank arrays were introduced in Fortran 2018, and many compilers and libraries seem to struggle with this feature. This PR implements the methods of MPI_Utilities.f90 with usual interfaces.
Closes #167