Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow setting a name for the form #4933

Merged
merged 2 commits into from
Nov 8, 2024
Merged

feat: allow setting a name for the form #4933

merged 2 commits into from
Nov 8, 2024

Conversation

genu
Copy link
Contributor

@genu genu commented Nov 8, 2024

🔎 Overview
This adds ability to set a name for a form so that it can be distinguished in the devtools.

CleanShot X 2024-11-08 12 01 30

🤓 Code snippets/examples (if applicable)

A name can be set in the component:

<Form name="FormA">
....
</Form>

or in the composable:

const form = useForm({
   name: "FormA"
});

Issues affected

Closes #4930

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.25%. Comparing base (abf2af1) to head (17e2a12).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4933      +/-   ##
==========================================
+ Coverage   89.24%   89.25%   +0.01%     
==========================================
  Files          93       93              
  Lines        7986     7995       +9     
  Branches     1386     1387       +1     
==========================================
+ Hits         7127     7136       +9     
  Misses        852      852              
  Partials        7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@logaretm logaretm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@logaretm logaretm merged commit b81ec50 into logaretm:main Nov 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to set a name for the forms to better distinguish them in the devtools
3 participants