Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avro codec read schema and partial deserialization #35

Merged
merged 6 commits into from
Aug 21, 2020
Merged

Avro codec read schema and partial deserialization #35

merged 6 commits into from
Aug 21, 2020

Conversation

lucabelluccini
Copy link
Contributor

This PR adds a comment/warning regarding partial deserialization of Avro codecs.
This is slightly linked to #28

jsvd
jsvd reviewed Aug 21, 2020
View reviewed changes
Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work on this Luca, can you bump the patch version and add an entry to the changelog so we can publish this doc change?

@jsvd jsvd requested a review from karenzone August 21, 2020 14:43
@jsvd
Copy link
Member

jsvd commented Aug 21, 2020

@karenzone we don't have docs builds here, can you confirm this formatting pleases the Ascii M.D.?

@karenzone karenzone added the docs label Aug 21, 2020
karenzone
karenzone approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds cleanly, renders correctly, and LGTM! Thanks for adding this clarification.

@karenzone karenzone merged commit 07bd281 into logstash-plugins:master Aug 21, 2020
@karenzone
Copy link
Contributor

PUBLISHED:
Screen Shot 2020-08-21 at 2 02 59 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsvd jsvd jsvd left review comments

@karenzone karenzone karenzone approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucabelluccini @jsvd @karenzone