Exceptions are expensive and may be avoided for lookup misses #60
Assignees
Comments
yaauie
added a commit
to yaauie/logstash-filter-dns
that referenced
this issue
Jan 3, 2020
yaauie
added a commit
to yaauie/logstash-filter-dns
that referenced
this issue
Jan 4, 2020
By using `Resolv#each_name` and `Resolv#each_address`, and returning the first match from the block or returning nil if no matches were found, we can mirror the behavior of `Resolv#getname` and `Resolv#getaddress` without raising exceptions on lookup misses. Adjusts flow-control to handle a nil return value as a lookup miss instead of relying on exception handlers. Resolves: logstash-plugins#60
yaauie
added a commit
that referenced
this issue
Jan 6, 2020
By using `Resolv#each_name` and `Resolv#each_address`, and returning the first match from the block or returning nil if no matches were found, we can mirror the behavior of `Resolv#getname` and `Resolv#getaddress` without raising exceptions on lookup misses. Adjusts flow-control to handle a nil return value as a lookup miss instead of relying on exception handlers. Resolves: #60
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
ResolvAPIs this plugin uses throw exceptions when there is no name associated with an address (or vice versa; read: lookup miss, not lookup failure), and our implmentation relies on these costly exceptions for flow control (Resolv#getname(address),Resolv#getaddress(name)).But
Resolvalso provides public APIs that treat a lookup misses as non-exceptional (Resolv#each_name(address,&block),Resolv#each_address(name,&block), which still handle lookup failure exceptionally). I believe that we should look into using these APIs, and will need to modify our implementation to handle these lookup misses in the normal (non-exceptional) flow control.The text was updated successfully, but these errors were encountered: