check if ES is licensed before pushing out events to it #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsvd
force-pushed
the
default_distro_check
branch
3 times, most recently
from
ad2188e to
49b11cb
Compare
jsvd
force-pushed
the
default_distro_check
branch
from
49b11cb to
d348e86
Compare
jsvd
changed the title
* don't mark connection as not alive. only log a warn
jsvd
force-pushed
the
default_distro_check
branch
from
d348e86 to
15cdcf4
Compare
robbavey
reviewed
Oct 7, 2019
There was a problem hiding this comment.
One small suggestion on adding a unit test.
Also, do we need to add a documentation note anywhere here that connecting to oss Elasticsearch from a default Logstash will result in a warning (and from 8.x will be marked as unlicensed)
The build error on 8.x looks unrelated to this change, but an actual issue
jsvd
commented
Oct 8, 2019
|
many thanks @robbavey |
35 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when running a default logstash distribution we should error out if the elasticsearch distribution is oss. this makes logstash behave like beats