Implement Composable Templates to support Elasticsearch 8.0 #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elasticsearch into composable_index_template
kaisecheng
changed the title
kaisecheng
assigned elasticsearch-bot, kaisecheng and colinsurprenant and unassigned elasticsearch-bot and kaisecheng
spec/es_spec_helper.rb
Outdated
| @@ -59,7 +59,12 @@ def default_mapping_from_mappings(mappings) | |||
| end | |||
|
|
|||
| def field_properties_from_template(template_name, field) | |||
| mappings = @es.indices.get_template(name: template_name)[template_name]["mappings"] | |||
| template = get_template(@es, template_name) | |||
| mappings = if ESHelper.es_version_satisfies?(">=8") | |||
There was a problem hiding this comment.
suggestion: maybe for consistency we could also have a get_mapping method similar to get_template?
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elasticsearch's /_template API is being deprecated in 7.8, this PR migrate to Composable Templates (see: elastic/elasticsearch#53101).
Fix: #944
_index_templateto manage template if elasticsearch version >= 8priorityset for default usage