feat(core): added a new endpoint to replace user roles #3203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/core/src/mocks/index.ts | 📈 +270 Bytes |
| packages/core/src/routes/admin-user-role.test.ts | 📈 +524 Bytes |
| packages/core/src/routes/admin-user-role.ts | 📈 +1.14 KB |
Uffizzi Ephemeral Environment
|
charIeszhao
reviewed
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The api endpoint
POST /api/users/:userId/rolesacceptsroleIds[]to assign roles to the user. As relevant to my use case, I implemented aPUT /api/users/:userId/rolesto replace user's roles. Hoping to see this commit merged as I guess it might find its place in other projects as well.Refer to here, Discord thread for origin of this:
https://discord.com/channels/965845662535147551/1077713036485349587
Testing
I've created relevant tests that you can see in committed files and they are part of usual test process.