Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schemas,core,console): add SAML application type #6766

Merged
merged 4 commits into from
Nov 21, 2024

Conversation

darcyYe
Copy link
Contributor

@darcyYe darcyYe commented Nov 4, 2024

Summary

add SAML application type, with following changes:

  1. add SAML to enum application type
  2. can not create/update/delete SAML apps with POST /applications and PATCH/DEL /applications/:id APIs
  3. update the type in @logto/console as well to prevent build errors resulted by adding possible SAML value to application.type type.

Testing

Should be covered by integration tests.

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

Copy link

github-actions bot commented Nov 4, 2024

COMPARE TO master

Total Size Diff 📈 +6.1 KB

Diff by File
Name Diff
packages/console/src/components/ApplicationCreation/CreateForm/index.tsx 📈 +136 Bytes
packages/console/src/components/ApplicationIcon/index.tsx 📈 +186 Bytes
packages/console/src/components/Guide/hooks.ts 📈 +289 Bytes
packages/console/src/components/ItemPreview/ApplicationPreview.tsx 📈 +244 Bytes
packages/console/src/consts/applications.ts 📈 +107 Bytes
packages/console/src/pages/ApplicationDetails/ApplicationDetailsContent/GuideDrawer/index.tsx 📈 +489 Bytes
packages/console/src/pages/ApplicationDetails/ApplicationDetailsContent/index.tsx 📈 +240 Bytes
packages/console/src/pages/EnterpriseSsoDetails/IdpInitiatedAuth/ConfigForm.tsx 📈 +608 Bytes
packages/core/src/routes/applications/application.ts 📈 +526 Bytes
packages/integration-tests/src/tests/api/application/application.secrets.test.ts 📈 +113 Bytes
packages/integration-tests/src/tests/api/application/application.test.ts 📈 +422 Bytes
packages/integration-tests/src/tests/console/applications/constants.ts 📈 +69 Bytes
packages/phrases/src/locales/en/errors/application.ts 📈 +88 Bytes
packages/schemas/alterations/next-1731900596-add-saml-application-type.ts 📈 +1.88 KB
packages/schemas/alterations/next-1731900631-add-saml-app-third-party-consistency-check.ts 📈 +569 Bytes
packages/schemas/src/utils/application.ts 📈 +93 Bytes
packages/schemas/tables/applications.sql 📈 +137 Bytes

@github-actions github-actions bot added feature Cool stuff size/s labels Nov 4, 2024
@darcyYe darcyYe force-pushed the yemq-log-10133-add-isVisible-to-applications-table branch 3 times, most recently from b5bb11c to 81b6722 Compare November 7, 2024 08:59
@github-actions github-actions bot added size/m and removed size/s labels Nov 7, 2024
@darcyYe darcyYe changed the title feat(schemas): add isVisible to applications table feat(schemas): add SAML application type Nov 7, 2024
@darcyYe darcyYe force-pushed the yemq-log-10133-add-isVisible-to-applications-table branch 2 times, most recently from 87d77d1 to d70989d Compare November 7, 2024 18:38
@darcyYe darcyYe force-pushed the yemq-log-10133-add-isVisible-to-applications-table branch from f2bec19 to 18837d3 Compare November 8, 2024 04:43
@darcyYe darcyYe marked this pull request as ready for review November 8, 2024 06:18
@darcyYe darcyYe force-pushed the yemq-log-10133-add-isVisible-to-applications-table branch from 18837d3 to 71193e0 Compare November 8, 2024 10:02
@darcyYe darcyYe force-pushed the yemq-log-10133-add-isVisible-to-applications-table branch from 71193e0 to f604112 Compare November 18, 2024 03:31
@github-actions github-actions bot added size/l and removed size/m labels Nov 18, 2024
@darcyYe darcyYe force-pushed the yemq-log-10133-add-isVisible-to-applications-table branch 2 times, most recently from fde0600 to d5c8533 Compare November 18, 2024 10:47
@darcyYe darcyYe force-pushed the yemq-log-10133-add-isVisible-to-applications-table branch from d5c8533 to 8ede93b Compare November 18, 2024 11:01
@darcyYe darcyYe changed the title feat(schemas): add SAML application type feat(schemas,core,console): add SAML application type Nov 18, 2024
@darcyYe darcyYe force-pushed the yemq-log-10133-add-isVisible-to-applications-table branch from 8ede93b to 3a47e75 Compare November 20, 2024 06:32
@darcyYe darcyYe force-pushed the yemq-log-10133-add-isVisible-to-applications-table branch from 3a47e75 to dcfa9cd Compare November 21, 2024 06:18
@github-actions github-actions bot added size/m and removed size/l labels Nov 21, 2024
@darcyYe darcyYe force-pushed the yemq-log-10133-add-isVisible-to-applications-table branch from dcfa9cd to d947275 Compare November 21, 2024 06:54
@darcyYe darcyYe force-pushed the yemq-log-10133-add-isVisible-to-applications-table branch from d947275 to e47545a Compare November 21, 2024 06:59
Copy link
Contributor

@simeng-li simeng-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darcyYe darcyYe merged commit e97e63c into master Nov 21, 2024
38 checks passed
@darcyYe darcyYe deleted the yemq-log-10133-add-isVisible-to-applications-table branch November 21, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants