Reduce unnecessary updates #22
Conversation
| // IME fix | ||
| if ( | ||
| view.value.composing || // IME fix | ||
| view.value.state.doc.toJSON().join('\n') === value // don't need to update |
There was a problem hiding this comment.
This can be simplified as view.value.state.doc.toString() === value according to https://codemirror.net/docs/ref/#state.Text.toString.
There was a problem hiding this comment.
Note, 1. toString is only added to index.d.ts 6.2.x though it works fine on 6.1.4; 2. regardless the version, ESLint will (wrongly?) report error no-base-to-string.
There was a problem hiding this comment.
It works well but I got a warning, seems there are some type definition issues
There was a problem hiding this comment.
yeah, I noticed the same issue. Actually, I commented after I found the issue but forgot the commit the comment :)
There was a problem hiding this comment.
Then should we still use it like (view.value.state.doc as any).toString()? I would prefer the current one, we can fix it after bumping the version.
No description provided.