[Feature] update packages versions #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
yotamloe
reviewed
Dec 31, 2024
| <groupId>org.assertj</groupId> | ||
| <artifactId>assertj-core</artifactId> | ||
| <version>3.4.1</version> | ||
| <scope>test</scope> |
There was a problem hiding this comment.
I think this should stay at test scope
There was a problem hiding this comment.
I removed it from this package because assertj-core is coming from the logzio-java-sender:
https://github.com/logzio/logzio-java-sender/blob/master/pom.xml#L150C1-L155C1
yotamloe
reviewed
Dec 31, 2024
| @@ -90,7 +90,7 @@ public void validateJsonMessage(){ | |||
| } | |||
|
|
|||
| @Test | |||
| public void simpleAppending() throws Exception { | |||
There was a problem hiding this comment.
Why we need to remove throws Exception ?
There was a problem hiding this comment.
I removed it from all the methods that don't throw any exceptions (that had warning on them Exception 'java.lang.Exception' is never thrown in the method)
yotamloe
approved these changes
Dec 31, 2024
This was referenced Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
logzio-senderto version2.1.0integer multiplication implicitly cast to longwarning (Thread.sleep casting1000>>1000L)What type of PR is this?
(check all applicable)
Added tests?