Merge pull request quarkusio#6929 from aloubyansky/mvn-decrypt-fixes

Remove stacktrace logging when Maven's settings-security.xml could not be located
loicmathieu · Feb 3, 2020 · 4cc69f1 · 4cc69f1
2 parents 5475d84 + 606de18
commit 4cc69f1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/...ootstrap/core/src/main/java/io/quarkus/bootstrap/resolver/maven/MavenRepoInitializer.java b/...ootstrap/core/src/main/java/io/quarkus/bootstrap/resolver/maven/MavenRepoInitializer.java
@@ -201,9 +201,10 @@ public static DefaultRepositorySystemSession newSession(RepositorySystem system,
         decrypt.setProxies(settings.getProxies());
         decrypt.setServers(settings.getServers());
         final SettingsDecryptionResult decrypted = new SettingsDecrypterImpl().decrypt(decrypt);
-        if(decrypted.getProblems().isEmpty()) {
+        if(!decrypted.getProblems().isEmpty() && log.isDebugEnabled()) {
+            // this is how maven handles these
             for(SettingsProblem p : decrypted.getProblems()) {
-                log.warn("Problem decrypting maven settings: " + p);
+                log.debug(p.getMessage(), p.getException());
             }
         }
 

diff --git a/...s/bootstrap/core/src/main/java/io/quarkus/bootstrap/resolver/maven/SecDispatcherImpl.java b/...s/bootstrap/core/src/main/java/io/quarkus/bootstrap/resolver/maven/SecDispatcherImpl.java
@@ -3,7 +3,6 @@
 import java.util.HashMap;
 import java.util.Map;
 import java.util.StringTokenizer;
-
 import org.sonatype.plexus.components.cipher.DefaultPlexusCipher;
 import org.sonatype.plexus.components.cipher.PlexusCipher;
 import org.sonatype.plexus.components.cipher.PlexusCipherException;
@@ -106,7 +105,6 @@ public String decrypt( String str )
         }
         catch ( Exception e )
         {
-            e.printStackTrace();
             throw new SecDispatcherException(e);
         }
     }