Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GiveItem): GiveItem Item Exploit #16

Merged
merged 1 commit into from
Jan 3, 2022
Merged

fix(GiveItem): GiveItem Item Exploit #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 17 additions & 14 deletions server/main.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1413,21 +1413,24 @@ RegisterServerEvent("inventory:server:GiveItem", function(target, inventory, ite
if amount == 0 then
amount = item.amount
end
if OtherPlayer.Functions.AddItem(item.name, amount, false, item.info) then
TriggerClientEvent('inventory:client:ItemBox',target, QBCore.Shared.Items[item.name], "add")
TriggerClientEvent('QBCore:Notify', target, "You Received "..amount..' '..item.label.." From "..Player.PlayerData.charinfo.firstname.." "..Player.PlayerData.charinfo.lastname)
TriggerClientEvent("inventory:client:UpdatePlayerInventory", target, true)
Player.Functions.RemoveItem(item.name, amount, item.slot)
TriggerClientEvent('inventory:client:ItemBox',src, QBCore.Shared.Items[item.name], "remove")
TriggerClientEvent('QBCore:Notify', src, "You gave " .. OtherPlayer.PlayerData.charinfo.firstname.." "..OtherPlayer.PlayerData.charinfo.lastname.. " " .. amount .. " " .. item.label .."!")
TriggerClientEvent("inventory:client:UpdatePlayerInventory", src, true)
TriggerClientEvent('qb-inventory:client:giveAnim', src)
TriggerClientEvent('qb-inventory:client:giveAnim', target)
if Player.Functions.RemoveItem(item.name, amount, item.slot) then
if OtherPlayer.Functions.AddItem(item.name, amount, false, item.info) then
TriggerClientEvent('inventory:client:ItemBox',target, QBCore.Shared.Items[item.name], "add")
TriggerClientEvent('QBCore:Notify', target, "You Received "..amount..' '..item.label.." From "..Player.PlayerData.charinfo.firstname.." "..Player.PlayerData.charinfo.lastname)
TriggerClientEvent("inventory:client:UpdatePlayerInventory", target, true)
TriggerClientEvent('inventory:client:ItemBox',src, QBCore.Shared.Items[item.name], "remove")
TriggerClientEvent('QBCore:Notify', src, "You gave " .. OtherPlayer.PlayerData.charinfo.firstname.." "..OtherPlayer.PlayerData.charinfo.lastname.. " " .. amount .. " " .. item.label .."!")
TriggerClientEvent("inventory:client:UpdatePlayerInventory", src, true)
TriggerClientEvent('qb-inventory:client:giveAnim', src)
TriggerClientEvent('qb-inventory:client:giveAnim', target)
else
TriggerClientEvent('QBCore:Notify', src, "The other players inventory is full!", "error")
TriggerClientEvent('QBCore:Notify', target, "Your inventory is full!", "error")
TriggerClientEvent("inventory:client:UpdatePlayerInventory", src, false)
TriggerClientEvent("inventory:client:UpdatePlayerInventory", target, false)
end
else
TriggerClientEvent('QBCore:Notify', src, "The other players inventory is full!", "error")
TriggerClientEvent('QBCore:Notify', target, "Your inventory is full!", "error")
TriggerClientEvent("inventory:client:UpdatePlayerInventory", src, false)
TriggerClientEvent("inventory:client:UpdatePlayerInventory", target, false)
TriggerClientEvent('QBCore:Notify', src, "You do not have enough of the item!", "error")
end
else
TriggerClientEvent('QBCore:Notify', src, "You do not have enough items to transfer")
Expand Down