Add model dimension calculation #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it ends up being tiny but whatever
|
@JnKTechstuff Sorry for the late reply, can you please fix the conflicts so I can merge? |
|
Should be good now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This simply calculated the model dimensions and accurately determines the back/front of vehicle with high accuracy. This also reduces the area to check down from 2.0 down to 1.5 since we are accurately getting this position. This fixes things like the trunk on box trucks being on the side because a set value is set even though every car is different.
Pull Request Checklist:
resourcein-game after the relevant change?