-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(LonaServer): Allow to set aiohttp client_max_size #224
Conversation
@SmithChart: looks good to me. There seems to be no downside to create the app directly in the LonaServer constructor. |
That is the AIOHTTP default value for this parameter.
Ack. I will update my PR with documentation. |
e9c3d9f
to
f17a8fe
Compare
Documentation and commit message updated. Please Review. |
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
=======================================
Coverage 62.25% 62.26%
=======================================
Files 67 67
Lines 4817 4818 +1
Branches 932 932
=======================================
+ Hits 2999 3000 +1
Misses 1565 1565
Partials 253 253
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Only some minor nitpicks. Besides them this looks ready to merge.
Can you remove the prefix "WIP: " when you are done?
:name: AIOHTTP_CLIENT_MAX_SIZE | ||
:path: lona.default_settings.AIOHTTP_CLIENT_MAX_SIZE | ||
|
||
.. note:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please remove this message? The next version could be 1.11 as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope I have understood correctly. I have now removed the ..note::
section.
Please hit that resolve-button yourself if that's what you wanted :-)
@SmithChart: Whats the state of this PR? |
With this change it is now possible to set the aiohttp ``client_max_size`` during the creation of the ``Application``. This value controls the maximum size of a POST request in bytes. This change basically moves the creation of the aiohttp ``Application`` from ``run_server.py`` and ``app.py`` into the ``LonaServer``. Signed-off-by: Chris Fiege <[email protected]>
f17a8fe
to
fe7edb6
Compare
Sorry for weeks of silence. First some intense weeks at work and afterwards some days vacation. |
@SmithChart: No worries :) I just wanted to make sure you are not waiting for me |
Looks good! Thanks for contributing :) |
With this change it is now possible to set the aiohttp
client_max_size
during the creation of theApplication
. Thisvalue controls the maximum size of a POST request in bytes.
This change basically moves the creation of the aiohttp
Application
from
run_server.py
andapp.py
into theLonaServer
.Closes #222
Let me know what you think.