Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump nfs-ganesha to v6.3 #396

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

james-munson
Copy link
Contributor

Which issue(s) this PR fixes:

Issue longhorn/longhorn#9979

What this PR does / why we need it:

Special notes for your reviewer:

Relies on new branch longhorn-ganesha-v6.3 in https://github.com/rancher/nfs-ganesha, with tag v6_20241216

Built but not yet tested.

Additional documentation or context

Copy link

coderabbitai bot commented Dec 17, 2024

Walkthrough

The pull request focuses on updating the Dockerfile for the NFS Ganesha project, specifically changing the source code version from v6_20241120 to v6_20241216. The modifications include platform-specific build configurations, ensuring support for linux/amd64 and linux/arm64 platforms, and maintaining the existing build process with specific feature flags. The update aims to incorporate the latest version of NFS Ganesha while preserving the existing build and deployment strategy.

Changes

File Change Summary
package/Dockerfile - Updated NFS Ganesha version from v6_20241120 to v6_20241216
- Added platform validation for linux/amd64 and linux/arm64
- Maintained existing build configuration and dependency installation

Assessment against linked issues

Objective Addressed Explanation
Upgrade NFS Ganesha to v6.3 [#9979]

Possibly related PRs

Suggested reviewers

  • innobead
  • c3y1huang

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7d69534 and 90165e6.

📒 Files selected for processing (1)
  • package/Dockerfile (1 hunks)
🔇 Additional comments (4)
package/Dockerfile (4)

Line range hint 28-36: Build configuration looks good.

The build configuration:

  • Maintains security by disabling unnecessary features (dbus, NLM, etc.)
  • Properly restricts FSAL support to VFS only
  • Uses appropriate compiler settings

Line range hint 1-78: Overall changes look good, but testing is required.

The version update and build configuration changes are well-structured. However, as mentioned in the PR description, testing hasn't been performed yet. Please ensure comprehensive testing is completed, particularly:

  1. NFS share creation and mounting
  2. File operations on mounted shares
  3. Performance comparison with the previous version

Line range hint 1-3: Verify base image version.

Please ensure that registry.suse.com/bci/bci-base:15.6 is the latest stable version available.


20-22: Verify version compatibility and changelog.

While the version update aligns with the PR objectives, please ensure:

  1. Compatibility between nfs-ganesha v6_20241216 and ntirpc v6.0.1
  2. Review of changes in the new version for potential breaking changes

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekbit derekbit merged commit 03f01bc into longhorn:master Dec 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants