-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump nfs-ganesha to v6.3 #396
Conversation
Signed-off-by: James Munson <[email protected]>
WalkthroughThe pull request focuses on updating the Dockerfile for the NFS Ganesha project, specifically changing the source code version from Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🔇 Additional comments (4)package/Dockerfile (4)Line range hint The build configuration:
Line range hint The version update and build configuration changes are well-structured. However, as mentioned in the PR description, testing hasn't been performed yet. Please ensure comprehensive testing is completed, particularly:
Line range hint Please ensure that registry.suse.com/bci/bci-base:15.6 is the latest stable version available.
While the version update aligns with the PR objectives, please ensure:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Which issue(s) this PR fixes:
Issue longhorn/longhorn#9979
What this PR does / why we need it:
Special notes for your reviewer:
Relies on new branch longhorn-ganesha-v6.3 in https://github.com/rancher/nfs-ganesha, with tag v6_20241216
Built but not yet tested.
Additional documentation or context