SimpleSchema.oneOf Issue (simple example included)

[zjzeit]

Below is the example case.
One case has type: FirstSchema
The other case has type: SimpleSchema.oneOf(String, Number, FirstSchema, ZeroSchema)
Given the second case contains the first case within oneOf, it should work.
Shouldn't oneOf test for String, then Number, then FirstSchema, and pass once it tests FirstSchema to be a match?

// Import
import SimpleSchema from 'simpl-schema';

// Instantiate
Test = new Mongo.Collection('test');

// Define Schema
ZeroSchema = new SimpleSchema({
	zeroAlpha: Number,
	zeroBravo: Number
});
FirstSchema = new SimpleSchema({
	firstAlpha: String,
	firstBravo: String
});
SecondSchema = new SimpleSchema({
	secondAlpha: String,
	secondBravo: {
		//type: FirstSchema, // Comment the below and un-comment this to switch cases
		type: SimpleSchema.oneOf(String, Number, FirstSchema, ZeroSchema)
	}
});

// Attach Schema
Test.attachSchema(SecondSchema);

// Sample Data
myData = {
	secondAlpha: "test",
	secondBravo: {
		firstAlpha: "test",
		firstBravo: "test"
	}
};
Test.insert(myData); // Error: secondBravo.firstAlpha is not allowed by the schema

Also interesting note: if I do type: SimpleSchema.oneOf(String, Number, FirstSchema), i.e., remove the ZeroSchema part, it validates/inserts successfully.

[williamtetlow]

Is there any news on this bug? I can confirm I'm having a similar issue, simple example:

const schemaOne = new SimpleSchema({
  itemRef: String,
  partNo: String,
});

const schemaTwo = new SimpleSchema({
  anotherIdentifier: String,
  partNo: String,
});

const combinedSchema = new SimpleSchema({
  item: SimpleSchema.oneOf(schemaOne, schemaTwo),
});

Test.attachSchema(combinedSchema);

Test.insert({ itemRef: 'hhh', partNo: 'ttt' }); // Error: item.itemRef is not allowed by the schema

I don't mind helping submit a PR to fix this? Multiple schemas is going to make this package really powerful!

[TheGame2500]

@williamtetlow if you've got the time and the knowledge to do this, can you please go ahead and do it, as the issue's labeled with 'help wanted' ? Otherwise, I'll do it, but I'm not that familiar with the library's internals, so it would take longer.

[pilarArr]

I've run on this issue too.

@zjzeit I found out that the last schema you put in the .oneOf() list is the one that prevails.
Any other insert or validation for the other schemas do not work.

Any new on this? @TheGame2500 did you manage to fix it?

[TheGame2500]

@pilarArr no. I was waiting on @williamtetlow to reply.

[williamtetlow]

@TheGame2500 Sorry been away on holiday. Yep I'll take a look at this over the next couple of days. From a quick scan of the code it doesn't look too difficult to fix.

[SnooHD]

Also ran into this issue, any progress? :)
For now i'm just skipping the object with blackbox: true.. but i would prefer not to.

[blueyestar]

I have same problem.

[ejfrancis]

+1 still a problem

[aldeed]

I've done some work on this, but it's a substantial rewrite to the validation flow. Hopefully will have a solution.

[KG32]

+1

[chrisbobbe]

Thanks for this useful package! Is help needed on this issue @aldeed ? I can see if I can put together a pull request, but I don't want to interfere if you have a substantial rewrite in progress.

[conorstrejcek]

We have a strong use-case for defining multiple schemas for a collection. Without full oneOf support, we are not able to validate more than one complex schema on a collection. Are there any plans to add support for nested Schemas within oneOf, and if not, would that be a welcome pull request?

[chrisbobbe]

Hi again, just checking in to see if there might be a solution in progress, or if you'd be interested in a pull request to fix this issue.

[chrisbobbe]

Hello @aldeed , if you add the "Help Wanted" flag again, I'll feel more comfortable working on a pull request. Again, I don't want to interfere if you're already working on it. Or, is there anyone else who's familiar with the internals of the package? It might take me longer, since I'm not, but I'm willing to go ahead with it because this is so important.

[gerwinbrunner]

Is there any progress on this issue?

[gerwinbrunner]

Any news?

[Roshdy]

So after 2 years and a half...now what? :D

[DrewHoo]

Yep, just hit this, would love to see a fix.

[aldeed]

Wow, needless to say this issue dropped off my radar. I really don't remember anything about what I was working on except that it was complicated to fix. I may have even given up trying but forgot to post here. Sorry, but if anyone can fix it without breaking any other tests, please submit a PR.

[baileywall]

any chance the above fix for this ^ is going to make it into the next release?

[weljoda]

Still facing the same Problem

[github-actions]

🎉 This issue has been resolved in version 3.3.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

If this makes you happy, please consider becoming a sponsor.

Your semantic-release bot 📦🚀