-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nightly to travis testing matrix and remove unsupported #43
Conversation
There's one failed test for 8.x
|
Copied the test looks for php 8 curl integration needs change main() : ct= 1; wt=*;
main()==>curl_close : ct= 1; wt=*;
-main()==>curl_exec#https://www.php.net/ : ct= 1; wt=*;
-main()==>curl_getinfo : ct= 1; wt=*;
+main()==>curl_exec : ct= 1; wt=*;
main()==>curl_init : ct= 1; wt=*;
main()==>curl_setopt : ct= 2; wt=*;
main()==>xhprof_disable : ct= 1; wt=*; also few build warnings
|
Fixes for
|
Curl changed return type to return object instead of resource, that's why test failed https://github.com/php/php-src/blob/master/UPGRADING#L948 |
@longxinH thank you for merging, I still found no way to fix curl |
The related change is php/php-src#5402 |
@andypost Thank you, is there any other solution I try |
I used to run the test to try get object but stuck at this line https://github.com/longxinH/xhprof/blob/master/extension/xhprof.c#L1519-L1520
|
It just type 8 (object) in 8+ so after #44 makes sense to create new release) |
7.0 and 7.1 is unsupported https://www.php.net/supported-versions.php