Button Generate password and chackbox show/hide password

[manieqq]

Hello, I have a proposal
To add a User Module button "Generete password" and show / hide password checkbox

We need to create a file in generate_password.js location: bonfire / modules / users / assets / js

file generate_password.js

function randomPassword(length) {
var chars = "abcdefghijklmnopqrstuvwxyz!@#$%^&*()-+<>ABCDEFGHIJKLMNOP1234567890";
var pass = "";
for (var x = 0; x < length; x++) {
var i = Math.floor(Math.random() * chars.length);
pass += chars.charAt(i);
}
return pass;
}

function generate() {
myform.password.value = randomPassword(myform.length.value);
myform.pass_confirm.value = myform.password.value;
}

(function() {

var PasswordToggler = function( element, field ) {
this.element = element;
this.field = field;

  this.toggle();  

};

PasswordToggler.prototype = {
toggle: function() {
var self = this;
self.element.addEventListener( "change", function() {
if( self.element.checked ) {
self.field.setAttribute( "type", "text" );
} else {
self.field.setAttribute( "type", "password" );
}
}, false);
}
};

document.addEventListener( "DOMContentLoaded", function() {
var checkbox = document.querySelector( "#show-hide" ),
password = document.querySelector( "#password" ),
form = document.querySelector( "#myform" );

      form.addEventListener( "submit", function( e ) {
          e.preventDefault();
      }, false);

      var toggler = new PasswordToggler( checkbox, password );

});

})();

then the controller: / bonfire / modules / users / controllers add code

Assets :: add_module_js ( 'users', 'generate_password.js');

and the last step in the files:
/bonfire/modules/users/views/settings/user_form.php

change:
echo form_open ($ this-> uri-> uri_string (), array ( 'class' => 'form-horizontal', 'autocomplete' => 'off'));
fix:
echo form_open ($ this-> uri-> uri_string (), array ( 'id' => 'myform', 'class' => 'form-horizontal', 'autocomplete' => 'off'));

and add line:

<input type="hidden" name="length" value="<? echo settings_item('auth.password_min_length'); ?>">

/bonfire/modules/users/views/user_fields.php

add code:

& Nbsp; <input type = "button" class = "button" value = "Generate" onClick = "generate ();" tabindex = "2">
        <Label for = "show-hide"> <input type = "checkbox" id = "show-hide" name = "show-hide" value = "" /> Show password </ label>
<Span class = "help-inline"> <? Php echo form_error ( 'password'); ?> </ Span>

change:

<Div class = "control-group <? Php echo form_error ( 'password')? $ ErrorClass: '';?>">
    <Label class = "control-label <? Php echo $ registerClass;?>" For = "password"> <? Php echo lang ( 'bf_password'); ?> </ Label>
    <Div class = "controls">
        <Input class = "<? Php echo $ controlClass;?>" Type = "password" id = "password" name = "password" value = "" />
<Span class = "help-inline"> <? Php echo form_error ( 'password'); ?> </ Span>
        <P class = "help-block"> <? Php echo isset ($ password_hints)? $ Password_hints: ''; ?> </ P>
    </ Div>
</ Div>

fix:

<Div class = "control-group <? Php echo form_error ( 'password')? $ ErrorClass: '';?>">
    <Label class = "control-label <? Php echo $ registerClass;?>" For = "password"> <? Php echo lang ( 'bf_password'); ?> </ Label>
    <Div class = "controls">
        <Input class = "<? Php echo $ controlClass;?>" Type = "password" id = "password" name = "password" value = "" />
& Nbsp; <input type = "button" class = "button" value = "Generate" onClick = "generate ();" tabindex = "2">
        <Label for = "show-hide"> <input type = "checkbox" id = "show-hide" name = "show-hide" value = "" /> Show password </ label>
<Span class = "help-inline"> <? Php echo form_error ( 'password'); ?> </ Span>
        <P class = "help-block"> <? Php echo isset ($ password_hints)? $ Password_hints: ''; ?> </ P>
    </ Div>
</ Div>

[OAVHomeAdmin]

Have all these commits been integrated already?