feat: Create NetStandard 2.0 library #1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
ksjoberg
force-pushed
the
netstandard-lib
branch
3 times, most recently
from
6df113d to
91a71e2
Compare
Split the library in two parts: One runtime library which targets .NET Standard 2.0 and one test library that targets .NET 6 and consumes the runtime library. This way, Xunit and other test-related libraries are not required to be deployed when referencing Look#. It is recommended to use the lowest/oldest .NET Standard version which under which your library can execute to maximize compatibility. In addition, add support for setting custom headers on a request-by-request basis. This is required because Looker requires the User-Agent header to be present when acquiring an embed session.
ksjoberg
force-pushed
the
netstandard-lib
branch
from
91a71e2 to
59d2b64
Compare
drstrangelooker
merged commit f5405fe
into
looker-open-source:netstandard-lib
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the .NET library in two parts: One runtime library which targets .NET Standard 2.0 and one test library that targets .NET 6 and consumes the runtime library. This way, Xunit and other test-related libraries are not required to be deployed when referencing Look#.
It is recommended to use the lowest/oldest .NET Standard version which under which your library can execute to maximize compatibility.
In addition, add support for setting custom headers on a request-by-request basis. This is required because Looker requires the User-Agent header to be present when acquiring an embed session.