Integration tests for generated methods.py #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed a minor bug in APIMethods._return happening when structure type is str - Also fixed a minor issue in _convert_query_params where json.dumps() was erroring when input is a raw string
- Fixed a minor bug in APIMethods._return happening when structure type is str - Also fixed a minor issue in _convert_query_params where json.dumps() was erroring when input is a raw string
joeldodge79
approved these changes
Aug 13, 2019
josephaxisa
pushed a commit
that referenced
this pull request
Sep 14, 2020
Initial check-in of Ruby SDK examples. These are based on the current Ruby SDK, not a codegen SDK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's also some formatting changes to the unit tests previously created.
TODOs:
get_test_datais an example of this. Another solution is to change it to a session scoped fixture.create_users@pytest.fixture). There's a flag to turn this off but I want to find a way to turn it off for a particular directory.pyyamlversions but those versions don't seem to work properly withpipenv. I will investigate further.