build: fix select-dist to preserve args #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix "bin/select-dist.js" used to run Mocha tests to quote all arguments in order to preserve glob patterns like "test/**/*.js" and pass them as-is to Mocha, instead of letting the Unix shell incorrectly expand "**" as "*".
raymondfeng
approved these changes
Oct 6, 2017
|
@virkt25 Travis CI failed in commit-linting step with the following error. Do you happen to know what can be causing it? I am landing this pull request as the linter error seems unrelated to my changes. |
|
@bajtos This was related to https://github.com/marionebl/commitlint/issues/87. config-lerna-scopes tripped up on changes in lerna internal API. |
|
@marionebl nice, thank you for fixing the issue and letting us know! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix "bin/select-dist.js" used to run Mocha tests to quote all arguments in order to preserve glob patterns like
test/**/*.jsand pass them as-is to Mocha, instead of letting the Unix shell incorrectly expand "**" as "*".Before this change (but after 3698d76), we were running only tests that are exactly two-levels deep in the
testdirectory tree, e.g.test/acceptance/{name}.js. With this change in place, we are running tests nested more deeply again, e.g.test/unit/router/metadata/param-body.test.jsThank you @raymondfeng and @kjdelisle for spotting the problem!