Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really like this library and would like to use it in selfoss RSS reader. Unfortunately, we target PHP 5.4 since it is still supported by Debian until May 2018, which many of our users run on shared web hosts.
Luckily, the library seems to work so we only need to de-bump constraints in
composer.json
. I also added linter to catch accidental uses of unsupported syntax.Could you please consider supporting 5.4 for one more year?
Edit: Hmm, it looks like
imagescale
is not supported on PHP 5.4 in addition to HHVM. Resize could be taken from this MIT library: https://github.com/claviska/SimpleImage/blob/3158283f02712928e51ff6e2f0bfcfeb31b48e66/src/claviska/SimpleImage.php#L756