Clean up custom pay-credit effects, cold read #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh of course! This is way better than mine. Love it! |
lostgeek
pushed a commit
that referenced
this pull request
May 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You'd mentioned not liking the double levels req :effect req :effect, so I thinned it by using
continue-abilityand treating:customlike an:effectability. Will make things like this much cleaner in the future too. Also, becausecasedefaults to last place or throws an error, I felt it best to remove the:customcatch.I also cleaned up Cold Read's implementation to setting a flag on the card instead of setting a flag on
state, and cleaned up the now irrelevant test.