Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First stab at GitHub Actions #1051

Merged
merged 9 commits into from
Oct 16, 2019
Merged

First stab at GitHub Actions #1051

merged 9 commits into from
Oct 16, 2019
+101 −183

Conversation

iMacTia
Copy link
Member

@iMacTia iMacTia commented Oct 14, 2019 •
edited
Loading

Description

First configuration of a CI workflow using GitHub Actions that runs Rubocop, Yard-Junk and Rspec.

Todos

List any remaining work that needs to be done, i.e:

  • Rubocop
  • Yard-Junk
  • RSpec
  • Rubygems deployment
  • CodeClimate

@iMacTia
First stab at GitHub Actions
1084944 
First configuration of a CI workflow using GitHub Actions that runs Rubocop, Yard-Junk and Rspec.
olleolleolle
olleolleolle reviewed Oct 14, 2019
View reviewed changes
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JUnit formatter creates an XML output which we will not read in GitHub Actions. CircleCI does good things with it.

@iMacTia
Removes CircleCI build.
8dd9ffe 
Adds badge to README.
Renames workflow.
Adds step to install libcurl (Patron dependency).
@iMacTia
Copy link
Member Author

iMacTia commented Oct 14, 2019

@olleolleolle I was wondering what that was, I thought it was related to CodeClimate 😅
Thanks for clarifying!

@iMacTia
Copy link
Member Author

iMacTia commented Oct 14, 2019

Looks good now but I had to explicitly install libcurl, which should not be necessary.
I've opened an issue here to shed some light on it

olleolleolle
olleolleolle reviewed Oct 14, 2019
View reviewed changes
@olleolleolle
Copy link
Member

The feedback runs are so fast.

@iMacTia
Copy link
Member Author

iMacTia commented Oct 14, 2019

Yeah it looks much faster than any external CI 😮!
When I opened the PR, it already started building as well so it was a better of seconds before I could see the result!

@iMacTia iMacTia force-pushed the GitHub-actions branch 6 times, most recently from 5deb409 to 1db095a Compare October 15, 2019 10:44
@iMacTia
Adds Publish workflow.
8870c7f 
Improves syntax spacing.
olleolleolle
olleolleolle previously approved these changes Oct 15, 2019
View reviewed changes
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

🚀 🚀 🚀
🎸 🎸 🎸
🤖 🤖 🤖

olleolleolle
olleolleolle approved these changes Oct 15, 2019
View reviewed changes
Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🤗 👍

@iMacTia iMacTia merged commit 708ca5b into master Oct 16, 2019
@iMacTia iMacTia deleted the GitHub-actions branch October 16, 2019 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iMacTia @olleolleolle