Rename Faraday::Logger::Formatter#error to #exception #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because #error is already delegated to the internal Logger, and could cause an infinite loop when the log_level is set to "error". Fixes #1467
olleolleolle
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename Faraday::Logger::Formatter#error to #exception
This is because #error is already delegated to the internal Logger, and could cause an infinite loop when the log_level is set to "error".
Fixes #1467
Additional Notes
Although this is technically a breaking change, I'll still release this as a hotfix release (2.7.2) because of the following:
on_error)log_levelis set to "error"errormethod. Considering this feature was released very recently, the chances of this happening are extremely small.cc @epaew in case you've built a custom formatter following your PR