-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Ruby 3.2.0 in Faraday v1.x #1483
Conversation
When adding a middleware that receives keyword arguments in the constructor, the call from `DependencyLoader#new` fails because the method is not defined using `ruby2_keywords`. This adds the required `ruby2_keywords` declaration to `DependencyLoader#new`, fixing the tests and getting Faraday v1.x working with Ruby 3.2.0. Fixes lostisland#1479.
There are some failing tests here - which at least according to my machine - seem to exist before my changes. Any ideas? 🙏 |
Apologies about that @timrogers, let me take a look |
Thank you ❤️ Apologies if my comment came across as a bit demanding - on re-reading it, it wasn't as kind as it could have been. I know that maintaining an open-source project is a thankless task! |
Not at all! I'm just surprised as to why this would start failing all of a sudden 🤔 |
Yeah. It definitely seems that it was green when the Actions CI ran at the time when it was merged. I too suspect a dependency update which is allowed by the gemspec/Gemfile. |
OK I managed to pinpoint it to |
@iMacTia Thanks! This is looking good now. |
@iMacTia Thanks for the quick review and merge. Looking forward to this getting shipped as the issue was noticed in my project, Restforce. |
Thank you @timrogers for fixing it 🙏 ! |
* Run tests against Ruby 3.2 * Declare `DependencyLoader#new` with `ruby2_keywords` to fix Ruby 3.2.0 When adding a middleware that receives keyword arguments in the constructor, the call from `DependencyLoader#new` fails because the method is not defined using `ruby2_keywords`. This adds the required `ruby2_keywords` declaration to `DependencyLoader#new`, fixing the tests and getting Faraday v1.x working with Ruby 3.2.0. Fixes lostisland#1479. Co-authored-by: Matt <[email protected]>
When adding a middleware that receives keyword arguments in the constructor, the call from
DependencyLoader#new
fails because the method is not defined usingruby2_keywords
.This adds the required
ruby2_keywords
declaration toDependencyLoader#new
, fixing the tests and getting Faraday v1.x working with Ruby 3.2.0.Fixes #1479.