Remove runtime dependency on base64

[Earlopain]

Description

#1525 removed a warning in ruby 3.3 because of the base64 dependency. Only a single method in one place is used so there's no need to pull it in. Since it's just a wrapper around the pack method it's trivial to replace.

Same approach by other gems:

• Remove base64 dependency rack/rack#2110
• [Fix #12310] Drop base64 gem from runtime dependency rubocop/rubocop#12313

[olleolleolle]

I like this approach. Thank you @Earlopain for bringing it up, in a PR.

(Seen other gems wrap local methods to break the gem dependency.)

Raises the question: Are there other gems in the Awesome Faraday list that sort of second-level depends on base64 being there for them?

[Earlopain]

Good point with the other parts of the ecosystem. I have checked every entry on the list and its looking pretty good. No direct usage, I haven't checked transitive dependencies however. The exception being faraday-jwt which I know needs some base64 functionality, see my note on that entry below

---

Anything relating to faraday inside the lostisland org no

Adapters

• async-http-faraday no
• faraday-typhoeus no
• faraday-http no
• httpx has implemented its own workaround for the base64 dependency (which I don't think is used in the adapter itself anyways) base64.rb

Middleware

• faraday-encoding no
• faraday-follow-redirects no
• faraday-parse_dates no
• faraday-cookie_jar no
• faraday-detailed_logger no
• faraday-encoding no
• faraday-http-cache no
• faraday-gzip no
• faraday-jwt not directly but through a dependency json-jwt. Not currently an issue since a transitive dependency apart from faraday takes care of it. I have openened Declare dependency on base64 nov/json-jwt#114
• faraday-mashify no
• faraday-oauth1 no
• faraday-follow-redirects no
• faraday-encode_xml no
• faraday-decode_xml no
• faraday-xml no

Speaking of the awesome faraday list, the json_request, json_response, and url_encoded links are currently 404. They are bundled in faraday itself so should be part of the check above.

[iMacTia]

Thank you for the fix and the thorough analysis @Earlopain.
This should be enough to confidently remove the dependency, and I'd add that if a downstream gem (middleware or adapter) requires base64 then it should also list it as a dependency rather than relying on Faraday 👍